Lee-W commented on code in PR #40478:
URL: https://github.com/apache/airflow/pull/40478#discussion_r1897151657
##########
airflow/models/dag.py:
##########
@@ -3314,7 +3316,14 @@ def bulk_write_to_db(
input_datasets[DatasetModel.from_public(dataset)] = None
curr_outlet_references = curr_orm_dag and
curr_orm_dag.task_outlet_dataset_references
for task in dag.tasks:
- dataset_outlets = [x for x in task.outlets or [] if
isinstance(x, Dataset)]
+ dataset_outlets: list[Dataset] = []
+ dataset_alias_outlets: list[DatasetAlias] = []
+ for outlet in task.outlets:
Review Comment:
I think Airflow is not expecting `outlets` to be used this way.
https://github.com/apache/airflow/blob/c083e456fa02c6cb32cdbe0c9ed3c3b2380beccd/airflow/models/baseoperator.py#L1103-L1121
@uranusjr WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
