shubhamraj-git commented on code in PR #45205:
URL: https://github.com/apache/airflow/pull/45205#discussion_r1897426673
##########
airflow/ui/src/pages/Variables/Variables.tsx:
##########
@@ -33,27 +33,30 @@ import {
} from "src/constants/searchParams";
import AddVariableModal from "./AddVariableModal";
+import { VariableActions } from "./VariableAction";
const columns: Array<ColumnDef<VariableResponse>> = [
{
accessorKey: "key",
header: "Key",
- meta: {
- skeletonWidth: 25,
- },
},
{
accessorKey: "value",
header: "Value",
- meta: {
- skeletonWidth: 25,
- },
},
{
accessorKey: "description",
header: "Description",
+ },
+ {
+ accessorKey: "actions",
+ cell: ({ row: { original } }) => (
+ <VariableActions variableKey={original.key} />
+ ),
+ enableSorting: false,
+ header: "Actions",
Review Comment:
I added the actions header, since everything was wrapped under a button, but
if we chose it to stay outside so it will be already visible to user, then
maybe we can leave it empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
