potiuk commented on code in PR #45261:
URL: https://github.com/apache/airflow/pull/45261#discussion_r1898902781


##########
.github/workflows/ci-image-build.yml:
##########
@@ -189,7 +159,17 @@ ${{ inputs.do-build == 'true' && inputs.image-tag || '' }}"
           GITHUB_USERNAME: ${{ github.actor }}
           PUSH: ${{ inputs.push-image }}
           VERBOSE: "true"
-        if: inputs.do-build == 'true'
-      - name: "Stop ARM instance"
-        run: ./scripts/ci/images/ci_stop_arm_instance.sh
-        if: always() && inputs.do-build == 'true' && inputs.platform == 
'linux/arm64'
+      - name: "Export docker storage"
+        run: >
+          ./scripts/ci/export_docker_image.sh
+          "ghcr.io/apache/airflow/main/ci/python${{ matrix.python-version }}"
+        if: inputs.upload-image-artifact == 'true'
+      - name: "Upload artifact"
+        uses: actions/upload-artifact@v4
+        with:
+          name: "ci-image-docker-dump-${{ inputs.platform }}-${{ 
matrix.python-version }}"
+          path: "/tmp/docker/image.tar"

Review Comment:
   ```suggestion
             path: "/tmp/docker-image.tar"
   ```



##########
.github/actions/prepare_breeze_and_image/action.yml:
##########
@@ -35,11 +35,23 @@ runs:
     - name: Login to ghcr.io
       shell: bash
       run: echo "${{ env.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ 
github.actor }} --password-stdin
-    - name: Pull CI image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}:${{ 
env.IMAGE_TAG }}
+    - name: Download CI image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}
+      uses: actions/download-artifact@v4
+      with:
+        name: "ci-image-docker-dump-${{ inputs.platform }}-${{ 
matrix.python-version }}"
+        path: "/tmp/docker/image.tar"

Review Comment:
   ```suggestion
           path: "/tmp/docker-image.tar"
   ```



##########
.github/actions/prepare_breeze_and_image/action.yml:
##########
@@ -35,11 +35,23 @@ runs:
     - name: Login to ghcr.io
       shell: bash
       run: echo "${{ env.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ 
github.actor }} --password-stdin
-    - name: Pull CI image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}:${{ 
env.IMAGE_TAG }}
+    - name: Download CI image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}
+      uses: actions/download-artifact@v4
+      with:
+        name: "ci-image-docker-dump-${{ inputs.platform }}-${{ 
matrix.python-version }}"
+        path: "/tmp/docker/image.tar"
+      if: inputs.pull-image-type == 'CI'
+    - name: Restore CI image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}
+      run: ./scripts/ci/import_docker_image.sh
       shell: bash
-      run: breeze ci-image pull --tag-as-latest
       if: inputs.pull-image-type == 'CI'
-    - name: Pull PROD image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}:${{ 
env.IMAGE_TAG }}
+    - name: Restore PROD image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}
+      uses: actions/download-artifact@v4
+      with:
+        name: "prod-image-docker-dump-${{ inputs.platform }}-${{ 
matrix.python-version }}"
+        path: "/tmp/docker/image.tar"

Review Comment:
   ```suggestion
           path: "/tmp/docker-image.tar"
   ```



##########
.github/actions/prepare_breeze_and_image/action.yml:
##########
@@ -35,11 +35,23 @@ runs:
     - name: Login to ghcr.io
       shell: bash
       run: echo "${{ env.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ 
github.actor }} --password-stdin
-    - name: Pull CI image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}:${{ 
env.IMAGE_TAG }}
+    - name: Download CI image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}
+      uses: actions/download-artifact@v4
+      with:
+        name: "ci-image-docker-dump-${{ inputs.platform }}-${{ 
matrix.python-version }}"
+        path: "/tmp/docker/image.tar"
+      if: inputs.pull-image-type == 'CI'
+    - name: Restore CI image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}
+      run: ./scripts/ci/import_docker_image.sh
       shell: bash
-      run: breeze ci-image pull --tag-as-latest
       if: inputs.pull-image-type == 'CI'
-    - name: Pull PROD image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}:${{ 
env.IMAGE_TAG }}
+    - name: Restore PROD image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}
+      uses: actions/download-artifact@v4
+      with:
+        name: "prod-image-docker-dump-${{ inputs.platform }}-${{ 
matrix.python-version }}"
+        path: "/tmp/docker/image.tar"

Review Comment:
   ```suggestion
           path: "/tmp/docker-image.tar"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to