shubhamraj-git commented on PR #45251: URL: https://github.com/apache/airflow/pull/45251#issuecomment-2564386485
> I believe that this is an artefact from the migration of public API from Connexion to Fast API, this validation was converted 1:1. The legacy UI was _not_ using the public API but was directly writing to DB. > > So technically we have two options: > > 1. Restrict changing the key in UI, make the key field read-only when editing > 2. Remove the validation in Rest API > 3. Add a UI specific API just for this > > From UI Perspective dis-allowing to change the key does not make sense. So I'd propose to remove the validation in REST API. For option 1 I see no reason. And Option 3 is too much overhead just because of a cross-validation in API > > Any other opinions? Regarding option 1) If we change the key itself, I think we actually created a new variable itself, Isn't this contradicting to edit behaviour? Like users will need to actual change the references too in that case. I think this can have a decision and can be fixed later, what say? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
