dstandish commented on a change in pull request #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r329361997
########## File path: airflow/models/base_async_operator.py ########## @@ -0,0 +1,96 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Base Asynchronous Operator for kicking off a long running +operations and polling for completion with reschedule mode. +""" +from functools import wraps +from airflow.sensors.base_sensor_operator import BaseSensorOperator +from airflow.exceptions import AirflowException +from airflow.models.xcom import XCOM_EXTERNAL_RESOURCE_ID_KEY + +class BaseAsyncOperator(BaseSensorOperator, SkipMixin): Review comment: I think that this operator actually makes more sense as a parent of sensor operator, rather than as a subclass of sensor operator. BaseSensorOperator is a BaseAsyncOperator that only checks status, does not submit request, and does not process result. Or maybe you should actually just make these changes directly to BaseSensorOperator, making it more generic rather than subclassing it. I am pretty sure you can do this while preserving backward compatibility. Either they have common ancestor, or async is parent. Either way, I think you need to orchestrate the submit request / process result from within the logic of sensor operator's current execute method. That way you only call `submit_request` on first run (which in sensor operator would not do anything) and only process result after poke successful (which again would not do anything in the sensor operator case). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
