jscheffl opened a new pull request, #45313:
URL: https://github.com/apache/airflow/pull/45313

   As reported in #45032 the CodeMirror entry boxes are not working.
   
   This is caused by how CodeMirror implements the entry: It is shadowing the 
original `<textarea>` fields in HTML. Unfortunately only via JavaScript the 
content of CodeMirror and HTML is in sync.
   ...and unfortunately my hand-written JavaScript checked for NULL/empty value 
_before_ getting to the fields from CodeMirror. So if an object or advanced 
array was initialized with an empty value, it never reached the onBlur() update 
action.
   Moved the check for empty _after_ the CodeMirror field check.
   
   Alongside figured out that the same as reported for advancedArray was also 
happening for object, just that the object field was never correctly 
initialized on empty value. Fixed this as well if a field is `type=["object", 
"null"]`.
   
   closes: #45032
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to