dabla commented on PR #44809:
URL: https://github.com/apache/airflow/pull/44809#issuecomment-2566948586
> Following dependency check is failing in breeze:
>
> ```
> pytest.param(
>
("providers/src/airflow/providers/standard/operators/bash.py",),
> {
> "selected-providers-list-as-string": "common.compat
standard",
> "all-python-versions": "['3.9']",
> "all-python-versions-list-as-string": "3.9",
> "python-versions": "['3.9']",
> "python-versions-list-as-string": "3.9",
> "ci-image-build": "true",
> "prod-image-build": "false",
> "needs-helm-tests": "false",
> "run-tests": "true",
> "run-amazon-tests": "false",
> "docs-build": "true",
> "run-kubernetes-tests": "false",
> "skip-pre-commits":
"identity,lint-helm-chart,mypy-airflow,mypy-dev,mypy-docs,mypy-providers,mypy-task-sdk,"
> "ts-compile-format-lint-ui,ts-compile-format-lint-www",
> "upgrade-to-newer-dependencies": "false",
> "core-test-types-list-as-string": "Always Core
Serialization",
> "providers-test-types-list-as-string":
"Providers[common.compat] Providers[standard]",
> "needs-mypy": "true",
> "mypy-checks": "['mypy-providers']",
> },
> id="Providers standard tests and Serialization tests to run
when airflow bash.py changed",
> ),
> ```
>
> @eladkal @potiuk This error is logical, as I needed to add the common sql
provider dependency as the GenericTransfer needs this dependency due to the
newly introduced SQLExecuteQueryTrigger used to allow the deferred paging
mechanism.
>
> But after some reflection, it still feels unlogical to me that the
GenericTransfer operator is part of the standard provider package, unless it
allows more than just transferring data from database to database? If not, it
would be more logical it resides in the common sql provider or I'm missing
something?
>
> I've been going through the code, and checked implementations of the
get_records and insert_rows method, which where all implemented by a Hook
extending the DbApiHook, but I suspect the DbApiHook was introduced after the
GenericTransfer already existed.
Hello @potiuk @eladkal could you check my above question whether it makes
sense or not? Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
