jason810496 commented on code in PR #45396:
URL: https://github.com/apache/airflow/pull/45396#discussion_r1903117799


##########
airflow/api_fastapi/core_api/datamodels/connections.py:
##########
@@ -94,3 +94,4 @@ class ConnectionBulkBody(BaseModel):
     """Connections Serializer for requests body."""
 
     connections: list[ConnectionBody]
+    overwrite: bool | None = Field(default=False)

Review Comment:
   > If the field has a default of `False` does it need to accept no value then?
   
   The `overwrite` field is intended to accept no value (i.e., to be optional), 
so the corresponding field in the generated OpenAPI schema will also be marked 
as optional.  
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to