potiuk commented on code in PR #45398: URL: https://github.com/apache/airflow/pull/45398#discussion_r1903141242
########## Dockerfile.ci: ########## @@ -1262,10 +1262,10 @@ COPY --from=scripts common.sh install_packaging_tools.sh install_additional_depe # Also use `force pip` label on your PR to swap all places we use `uv` to `pip` ARG AIRFLOW_PIP_VERSION=24.3.1 # ARG AIRFLOW_PIP_VERSION="git+https://github.com/pypa/pip.git@main"; -ARG AIRFLOW_UV_VERSION=0.5.11 +ARG AIRFLOW_UV_VERSION=0.5.14 # TODO(potiuk): automate with upgrade check (possibly) ARG AIRFLOW_PRE_COMMIT_VERSION="4.0.1" -ARG AIRFLOW_PRE_COMMIT_UV_VERSION="4.1.4" +ARG AIRFLOW_PRE_COMMIT_UV_VERSION="0.5.14" Review Comment: I just added AIRFLOW_PRE_COMMIT_UV_VERSION= replacement mirroring the `UV_VERSION=` . Since those are always run after, (in the same script) - they will make correct replacement in the end. Not too elegant but effective. ########## Dockerfile.ci: ########## @@ -1262,10 +1262,10 @@ COPY --from=scripts common.sh install_packaging_tools.sh install_additional_depe # Also use `force pip` label on your PR to swap all places we use `uv` to `pip` ARG AIRFLOW_PIP_VERSION=24.3.1 # ARG AIRFLOW_PIP_VERSION="git+https://github.com/pypa/pip.git@main"; -ARG AIRFLOW_UV_VERSION=0.5.11 +ARG AIRFLOW_UV_VERSION=0.5.14 # TODO(potiuk): automate with upgrade check (possibly) ARG AIRFLOW_PRE_COMMIT_VERSION="4.0.1" -ARG AIRFLOW_PRE_COMMIT_UV_VERSION="4.1.4" +ARG AIRFLOW_PRE_COMMIT_UV_VERSION="0.5.14" Review Comment: I just added AIRFLOW_PRE_COMMIT_UV_VERSION= replacements mirroring the `UV_VERSION=` . Since those are always run after, (in the same script) - they will make correct replacement in the end. Not too elegant but effective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
