shahar1 commented on code in PR #45403: URL: https://github.com/apache/airflow/pull/45403#discussion_r1903313156
########## docs/apache-airflow-providers-edge/install_on_windows.rst: ########## @@ -0,0 +1,94 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Install Edge Worker on Windows +============================== + +.. note:: + + The Edge Provider Package is an experimental preview. Features and stability is limited + and needs to be improved over time. Target is to have full support in Airflow 3. + Once Airflow 3 support contains Edge Provider, maintenance of the Airflow 2 package will + be dis-continued. + + This is also especially true for Windows. The Edge Worker is only manually tested on Windows + and the setup is not validated in CI. It is recommended to use Linux for Edge Worker. The + Windows-based setup is only for testing at your own risk. It is also technically limited + due to Python OS restrictions and rather a Proof-of-Concept quality. Review Comment: ```suggestion The Edge Provider Package is an experimental preview. Features and stability are limited, and need to be improved over time. The target is to achieve full support in Airflow 3. Once the Edge Provider is fully supported in Airflow 3, maintenance of the Airflow 2 package will be discontinued. This is also especially true for Windows. The Edge Worker has only been manually tested on Windows, and the setup is not validated in CI. It is recommended to use Linux for Edge Worker. The Windows-based setup is intended solely for testing at your own risk. It is technically limited due to Python OS restrictions and if currently of Proof-of-Concept quality. ``` ########## docs/apache-airflow-providers-edge/install_on_windows.rst: ########## @@ -0,0 +1,94 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Install Edge Worker on Windows +============================== + +.. note:: + + The Edge Provider Package is an experimental preview. Features and stability is limited + and needs to be improved over time. Target is to have full support in Airflow 3. + Once Airflow 3 support contains Edge Provider, maintenance of the Airflow 2 package will + be dis-continued. + + This is also especially true for Windows. The Edge Worker is only manually tested on Windows + and the setup is not validated in CI. It is recommended to use Linux for Edge Worker. The + Windows-based setup is only for testing at your own risk. It is also technically limited + due to Python OS restrictions and rather a Proof-of-Concept quality. + + +.. note:: + + As of Airflow 2.10.3, the ``edge`` provider package is not included in normal release cycle. + Thus you can not directly install it via: ``pip install 'apache-airflow[edge]'`` as the dependency + can not be downloaded. + + While it is in not-ready state, a wheel release package must be manually built from source tree + via ``breeze release-management prepare-provider-packages --include-not-ready-providers edge``.. + + +The setup was tested on Windows 10 with Python 3.12.8, 64-bit. +To setup a instance of Edge Worker on Windows, you need to follow the steps below: + +1. Install Python 3.9 or higher (This document was written using Python 3.12.8, 64-bit) Review Comment: ```suggestion 1. Install Python 3.9 or higher. ``` Already mentioned it above ########## docs/apache-airflow-providers-edge/install_on_windows.rst: ########## @@ -0,0 +1,94 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Install Edge Worker on Windows +============================== + +.. note:: + + The Edge Provider Package is an experimental preview. Features and stability is limited + and needs to be improved over time. Target is to have full support in Airflow 3. + Once Airflow 3 support contains Edge Provider, maintenance of the Airflow 2 package will + be dis-continued. + + This is also especially true for Windows. The Edge Worker is only manually tested on Windows + and the setup is not validated in CI. It is recommended to use Linux for Edge Worker. The + Windows-based setup is only for testing at your own risk. It is also technically limited + due to Python OS restrictions and rather a Proof-of-Concept quality. + + +.. note:: + + As of Airflow 2.10.3, the ``edge`` provider package is not included in normal release cycle. Review Comment: ```suggestion As of Airflow 2.10.4, the ``edge`` provider package is not included in normal release cycle. ``` (I assume?) ########## docs/apache-airflow-providers-edge/install_on_windows.rst: ########## @@ -0,0 +1,94 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Install Edge Worker on Windows +============================== + +.. note:: + + The Edge Provider Package is an experimental preview. Features and stability is limited + and needs to be improved over time. Target is to have full support in Airflow 3. + Once Airflow 3 support contains Edge Provider, maintenance of the Airflow 2 package will + be dis-continued. + + This is also especially true for Windows. The Edge Worker is only manually tested on Windows + and the setup is not validated in CI. It is recommended to use Linux for Edge Worker. The + Windows-based setup is only for testing at your own risk. It is also technically limited + due to Python OS restrictions and rather a Proof-of-Concept quality. + + +.. note:: + + As of Airflow 2.10.3, the ``edge`` provider package is not included in normal release cycle. + Thus you can not directly install it via: ``pip install 'apache-airflow[edge]'`` as the dependency + can not be downloaded. + Review Comment: ```suggestion Thus, it cannot be directly installed using: ``pip install 'apache-airflow[edge]'`` as the dependency cannot be downloaded. ``` ########## docs/apache-airflow-providers-edge/install_on_windows.rst: ########## @@ -0,0 +1,94 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Install Edge Worker on Windows +============================== + +.. note:: + + The Edge Provider Package is an experimental preview. Features and stability is limited + and needs to be improved over time. Target is to have full support in Airflow 3. + Once Airflow 3 support contains Edge Provider, maintenance of the Airflow 2 package will + be dis-continued. + + This is also especially true for Windows. The Edge Worker is only manually tested on Windows + and the setup is not validated in CI. It is recommended to use Linux for Edge Worker. The + Windows-based setup is only for testing at your own risk. It is also technically limited + due to Python OS restrictions and rather a Proof-of-Concept quality. + + +.. note:: + + As of Airflow 2.10.3, the ``edge`` provider package is not included in normal release cycle. + Thus you can not directly install it via: ``pip install 'apache-airflow[edge]'`` as the dependency + can not be downloaded. + + While it is in not-ready state, a wheel release package must be manually built from source tree + via ``breeze release-management prepare-provider-packages --include-not-ready-providers edge``.. + Review Comment: ```suggestion While it is in a not-ready state, a wheel release package must be manually built from source tree via ``breeze release-management prepare-provider-packages --include-not-ready-providers edge``.. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
