ferruzzi commented on code in PR #43340:
URL: https://github.com/apache/airflow/pull/43340#discussion_r1904639153


##########
airflow/metrics/base_stats_logger.py:
##########
@@ -31,55 +33,53 @@ class StatsLogger(Protocol):
 
     instance: StatsLogger | NoStatsLogger | None = None
 
-    @classmethod
     def incr(
         cls,
-        stat: str,
+        metric_name: str,

Review Comment:
   I guess maybe we should, but it's also an internal/private method (not part 
of the public API AFAICT)  so I don't know if we really need to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to