ashb commented on code in PR #44982:
URL: https://github.com/apache/airflow/pull/44982#discussion_r1905511028
##########
providers/src/airflow/providers/edge/executors/edge_executor.py:
##########
@@ -129,6 +129,34 @@ def execute_async(
)
)
+ @provide_session
+ def queue_workload(
+ self,
+ workload: Any, # Note actually "airflow.executors.workloads.All" but
not existing in Airflow 2.10
Review Comment:
Do we need to keep this edge executor provider working with 2.0, or
should/could we make use of this need Airflow 3?
##########
providers/src/airflow/providers/edge/cli/edge_command.py:
##########
@@ -191,6 +201,64 @@ def _get_sysinfo(self) -> dict:
"free_concurrency": self.free_concurrency,
}
+ def _launch_job(self, edge_job: EdgeJobFetched):
+ """Get the received job executed."""
+ process: Popen | Process
+ if AIRFLOW_V_3_0_PLUS:
Review Comment:
Nit: Could we pull each of these into separate functions -- `def
_launch_job_airflow_v3` etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
