kacpermuda commented on code in PR #45326:
URL: https://github.com/apache/airflow/pull/45326#discussion_r1908401351


##########
providers/src/airflow/providers/google/cloud/openlineage/utils.py:
##########
@@ -466,18 +467,19 @@ def inject_openlineage_properties_into_dataproc_job(
             - OpenLineage provider is not accessible.
             - The job type is not supported.
             - Automatic parent job information injection is disabled.
-            - Any OpenLineage properties with parent job information are 
already present
+            - Any OpenLineage properties with respective information are 
already present

Review Comment:
   Sure, I've rewritten it. This is the new version of this part of the 
docstring:
   ```
       This function does not remove existing configurations or modify the job 
definition in any way,
        except to add the required OpenLineage properties if they are not 
already present.
   
       The entire properties injection process will be skipped if any condition 
is met:
         - The OpenLineage provider is not accessible.
         - The job type is unsupported.
         - Both `inject_parent_job_info` and `inject_transport_info` are set to 
False.
   
       Additionally, specific information will not be injected if relevant 
OpenLineage properties already exist:
       Parent job information will not be injected if:
           - Any property prefixed with `spark.openlineage.parent` exists.
           - `inject_parent_job_info` is False.
       Transport information will not be injected if:
           - Any property prefixed with `spark.openlineage.transport` exists.
           - `inject_transport_info` is False.
   ```
   Does it look better now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to