utkarsharma2 commented on code in PR #45441: URL: https://github.com/apache/airflow/pull/45441#discussion_r1910360144
########## providers/src/airflow/providers/fab/auth_manager/cli_commands/utils.py: ########## @@ -25,17 +25,17 @@ from typing import TYPE_CHECKING from flask import Flask +from sqlalchemy.engine import make_url import airflow from airflow.configuration import conf from airflow.exceptions import AirflowConfigException -from airflow.www.app import make_url -from airflow.www.extensions.init_appbuilder import init_appbuilder -from airflow.www.extensions.init_session import init_airflow_session_interface -from airflow.www.extensions.init_views import init_plugins +from airflow.providers.fab.www.extensions.init_appbuilder import init_appbuilder +from airflow.providers.fab.www.extensions.init_session import init_airflow_session_interface +from airflow.providers.fab.www.extensions.init_views import init_plugins if TYPE_CHECKING: - from airflow.www.extensions.init_appbuilder import AirflowAppBuilder + from airflow.providers.fab.www.extensions.init_appbuilder import AirflowAppBuilder Review Comment: @vincbeck We don't have `add_permissions()` method in `from airflow.providers.fab.www.extensions.init_appbuilder import AirflowAppBuilder` class. Causing `airflow sync-perm` command to fail on the main branch. ``` Updating actions and resources for all existing roles webserver | Traceback (most recent call last): webserver | File "/usr/local/bin/airflow", line 8, in <module> webserver | sys.exit(main()) webserver | ^^^^^^ webserver | File "/usr/local/lib/python3.12/site-packages/airflow/__main__.py", line 58, in main webserver | args.func(args) webserver | File "/usr/local/lib/python3.12/site-packages/airflow/cli/cli_config.py", line 49, in command webserver | return func(*args, **kwargs) webserver | ^^^^^^^^^^^^^^^^^^^^^ webserver | File "/usr/local/lib/python3.12/site-packages/airflow/utils/cli.py", line 111, in wrapper webserver | return f(*args, **kwargs) webserver | ^^^^^^^^^^^^^^^^^^ webserver | File "/usr/local/lib/python3.12/site-packages/airflow/utils/providers_configuration_loader.py", line 55, in wrapped_function webserver | return func(*args, **kwargs) webserver | ^^^^^^^^^^^^^^^^^^^^^ webserver | File "/usr/local/lib/python3.12/site-packages/airflow/providers/fab/auth_manager/cli_commands/sync_perm_command.py", line 35, in sync_perm webserver | appbuilder.add_permissions(update_perms=True) webserver | ^^^^^^^^^^^^^^^^^^^^^^^^^^ webserver | AttributeError: 'AirflowAppBuilder' object has no attribute 'add_permissions'. Did you mean: '_add_permission'? ``` Is there an alternative method we should use? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
