shahar1 commented on PR #45563: URL: https://github.com/apache/airflow/pull/45563#issuecomment-2585187198
Apparently it is a **really** tough task, here are some insights: - A requirement for upgrading Sphinx to v7 is to merge https://github.com/apache/airflow-site/pull/1103 and create a new version for `sphinx_airflow_theme` (`0.1.0`). For now, I made a workaround by injecting the contents of the file that was modified via `Dockerfile.ci` (struggled with mounting it - created an [issue](https://github.com/apache/airflow/issues/45576) for anyone who wants to tackle it in the future). - When running only the build docs workflow, locally and on GitHub Actions, using `breeze build-docs apache-airflow docker-stack --docs-only --clean-build`, the build succeeds without any errors (see [GitHub Action workflow](https://github.com/apache/airflow/actions/runs/12722412749/job/35466510483)). When running the docs server locally, the extra spaces issue indeed persists - we need to find out how to modify the related CSS (no success with it so far).  - When running only the spellchecks workflow, locally and on GitHub Actions, using `breeze build-docs apache-airflow docker-stack --clean-build` (see raw [logs](https://productionresultssa15.blob.core.windows.net/actions-results/150f2642-909d-4db9-9c5d-8fbcbdac4d97/workflow-job-run-d861e44f-2bbb-5cfa-a1f8-37f87cf3d990/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-01-11T08%3A50%3A51Z&sig=VqIwiRSbgJv4DXcHviF0uu1tQNPJiaXCgdLlVnQ7eOM%3D&ske=2025-01-11T17%3A27%3A16Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-01-11T05%3A27%3A16Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-11-04&sp=r&spr=https&sr=b&st=2025-01-11T08%3A40%3A46Z&sv=2024-11-04) - BIG FILE warning) - we get a lot of weird errors. If you take a look at the logs, it often fails when parsing from `/opt/airflow/providers/src/airflow/providers/amazon/aws/hooks/ssm.py::SsmHook:: get_parameter_value`. If we figure it out, we will get - When running the workflow for building docs and spelling **altogether** (`breeze build-docs apache-airflow docker-stack --clean-build`), the build fails due to a large number of implicit errors (which might be related to the failure of the spelling checks?). - The [MyPy workflow](https://github.com/apache/airflow/actions/runs/12722412749/job/35466520027), but it doesn't seem too bad - in the worst case we just ignore it. I'll be happy for some help in solving some of the riddles above, it will gets us closer to upgrading to Sphinx 7 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
