bugraoz93 commented on code in PR #45300:
URL: https://github.com/apache/airflow/pull/45300#discussion_r1912094745


##########
airflow/cli/api/datamodels/_generated.py:
##########
@@ -0,0 +1,1300 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# generated by datamodel-codegen:
+#   filename:  http://0.0.0.0:9091/openapi.json
+#   version:   0.26.4
+
+from __future__ import annotations
+
+from datetime import datetime, timedelta
+from enum import Enum
+from typing import Annotated, Any, Optional, Union
+
+from pydantic import BaseModel, ConfigDict, Field, RootModel
+
+
+class AppBuilderMenuItemResponse(BaseModel):

Review Comment:
   Hi @jason810496,
   
   This is a good question. I made it like this to reduce dependency on Rest 
API (FastAPI). This means that CLI shouldn't be impacted and needs to be 
updated all the time when there is a change on the API end. Both can have 
separate flows when it comes to their lifecycles while releasing changes. This 
would allow us time to adapt. Otherwise, whoever doing changes to the data 
models on API will have to make mandatory changes to the CLI code else tests 
will fail. 
   
   Of course, there could be still an impact if there are breaking changes on 
the API end which can make some changes mandatory for CLI. I think if we think 
about this, this brought up another discussion point in [a section in the 
AIP-81](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=315493347#AIP81EnhancedSecurityinCLIviaIntegrationofAPI-ReleaseStrategy)
 which we should discuss with the broader group concerning release strategy of 
Apache Airflow CLI. For me, in the long run, we should reduce the dependencies 
as much as possible to make this real in case we would like to go with this 
route. This would %100 eliminate mandatory changes. 
   
   In [one of the dev 
calls](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=308153072#Airflow3Devcall:MeetingNotes-Summary.6)
 (8 August 2024) for Apache Airflow v3, there was a question and decision 
around this topic. Meanwhile, this doesn't mean they will have separate 
versions but may have separate flows to do their development while releasing 
newer versions together. Or maybe in the future, the decision could be on also 
releasing it similar to providers and TaskSDK as separate packages. In both 
cases, reducing this dependency will be useful. 
   
   > Should we split Webserver, SDK, CLI, Scheduler, and Triggerer into 
separately installable packages for the users, while the dev code is in same 
mono-repo? (@potiuk)
   > * The consensus was to wait until there is decent progress on AIP-72 
implementation, but there was a general agreement on splitting the packages out 
while keeping apache-airflow as a meta-package that brings it all together. The 
intention is not to have a separate version scheme or release these separately 
however unlike Providers.
   
   This decision meant we should lean forward making apache-airflow as a 
meta-package for these main components as possible. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to