jedcunningham commented on code in PR #45480:
URL: https://github.com/apache/airflow/pull/45480#discussion_r1913781422


##########
airflow/dag_processing/manager.py:
##########
@@ -756,7 +756,10 @@ def clear_nonexistent_import_errors(self, 
session=NEW_SESSION):
 
             if self._file_paths:
                 query = query.where(
-                    ParseImportError.filename.notin_([f.path for f in 
self._file_paths]),
+                    and_(

Review Comment:
   This doesn't seem right - we want to compare file/bundle combo, not just 
that the file doesn't exist in any bundle.



##########
airflow/www/views.py:
##########
@@ -1019,7 +1019,10 @@ def index(self):
                     import_errors = import_errors.where(
                         ParseImportError.filename.in_(
                             
select(DagModel.fileloc).distinct().where(DagModel.dag_id.in_(filter_dag_ids))
-                        )
+                        ),
+                        ParseImportError.bundle_name.in_(

Review Comment:
   Same here - we need to check the combo, not separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to