jedcunningham commented on code in PR #44752:
URL: https://github.com/apache/airflow/pull/44752#discussion_r1913855141
##########
task_sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -294,8 +296,21 @@ def parse(what: StartupDetails) -> RuntimeTaskInstance:
from airflow.models.dagbag import DagBag
+ bundle_info = what.bundle_info
+
+ if TYPE_CHECKING:
+ assert bundle_info
+ import os
Review Comment:
nit: global import?
##########
task_sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -574,20 +575,21 @@ class ActivitySubprocess(WatchedSubprocess):
@classmethod
def start( # type: ignore[override]
cls,
- path: str | os.PathLike[str],
+ dag_rel_path: str | os.PathLike[str],
what: TaskInstance,
client: Client,
target: Callable[[], None] = _subprocess_main,
logger: FilteringBoundLogger | None = None,
+ bundle_info=None,
Review Comment:
nit: should we move this up next to the path?
##########
airflow/models/dagbundle.py:
##########
@@ -39,5 +39,7 @@ class DagBundleModel(Base):
latest_version = Column(String(200), nullable=True)
last_refreshed = Column(UtcDateTime, nullable=True)
- def __init__(self, *, name: str):
+ def __init__(self, *, name: str, latest_version=None, last_refreshed=None):
self.name = name
+ self.latest_version = latest_version
Review Comment:
Did you end up using these somewhere? I'd intentionally left them off, as
specifying them during construction didn't feel useful.
##########
tests/dag_processing/bundles/test_dag_bundle_manager.py:
##########
@@ -1,4 +1,5 @@
# Licensed to the Apache Software Foundation (ASF) under one
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
```suggestion
```
:)
##########
task_sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -294,8 +296,21 @@ def parse(what: StartupDetails) -> RuntimeTaskInstance:
from airflow.models.dagbag import DagBag
+ bundle_info = what.bundle_info
+
+ if TYPE_CHECKING:
+ assert bundle_info
+ import os
+
+ os.environ["AIRFLOW__DAG_BUNDLES__BACKENDS"]
Review Comment:
```suggestion
```
dead code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
