vincbeck commented on code in PR #45025:
URL: https://github.com/apache/airflow/pull/45025#discussion_r1915407494
##########
providers/src/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -225,6 +226,7 @@ def _export_entire_data(self):
finally:
if err is None:
_upload_file_to_s3(f, self.s3_bucket_name,
self.s3_key_prefix, self.dest_aws_conn_id)
+ return None
Review Comment:
Not sure this is needed
##########
providers/tests/amazon/aws/transfers/test_dynamodb_to_s3.py:
##########
@@ -324,8 +324,9 @@ def
test_dynamodb_execute_calling_export_table_to_point_in_time(self, _export_ta
point_in_time_export=True,
export_time=datetime(year=1983, month=1, day=1),
)
- dynamodb_to_s3_operator.execute(context={})
+ export_arn = dynamodb_to_s3_operator.execute(context={})
_export_table_to_point_in_time.assert_called()
+ assert export_arn is not None
Review Comment:
Could you mock the exported arn using `_export_table_to_point_in_time` and
expect that the returned value is the value you set in the mock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
