eladkal commented on code in PR #45619:
URL: https://github.com/apache/airflow/pull/45619#discussion_r1915496716


##########
providers/src/airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -208,6 +210,7 @@ def __init__(
         self.poll_interval = poll_interval
         self.awslogs_enabled = awslogs_enabled
         self.awslogs_fetch_interval = awslogs_fetch_interval
+        self.timeout = timeout

Review Comment:
   Please lets not use `timeout`.
   You can use the same name as boto3 or choose something else but not names 
that can cause confusion with BaseOperator parameters.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to