Lee-W commented on code in PR #45370:
URL: https://github.com/apache/airflow/pull/45370#discussion_r1916007045
##########
providers/tests/openlineage/plugins/test_listener.py:
##########
@@ -80,20 +79,30 @@ def regular_call(self, callable, callable_name, use_fork):
def test_listener_does_not_change_task_instance(render_mock, xcom_push_mock):
render_mock.return_value = render_df()
+ date = dt.datetime(2022, 1, 1)
Review Comment:
Nit: looks like start_date. Should we name it that way for explicity?
##########
airflow/models/dag.py:
##########
@@ -1727,86 +1727,63 @@ def add_logger_if_needed(ti: TaskInstance):
@provide_session
def create_dagrun(
self,
- state: DagRunState,
*,
- triggered_by: DagRunTriggeredByType | None,
- logical_date: datetime | None = None,
- run_id: str | None = None,
- start_date: datetime | None = None,
- external_trigger: bool | None = False,
+ run_id: str,
+ logical_date: datetime,
+ data_interval: tuple[datetime, datetime],
Review Comment:
Is the type expected to be different from the one above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
