XD-DENG commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330455370
########## File path: setup.py ########## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])): 'sphinxcontrib-httpdomain>=1.7.0', ] docker = ['docker~=3.0'] +drill = [ + 'pydrill>=0.3.4', + 'sqlalchemy-drill@' + 'git+https://github.com/aksakalli/sqlalchemy-drill.git@master#egg=sqlalchemy-drill==2.22.0' Review comment: I'm not sure if it's a good idea to introduce dependency in such a way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services