ashb commented on a change in pull request #6237: AIRFLOW-5581: Join
KubernetesJobWatcher in terminate call
URL: https://github.com/apache/airflow/pull/6237#discussion_r330564678
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -576,6 +576,7 @@ def _labels_to_key(self, labels):
def terminate(self):
"""Termninates the watcher."""
self.watcher_queue.join()
+ self.kube_watcher.join()
Review comment:
I don't think this is right. This doesn't signal in any way to the
kube_watcher that it should shutdown - it simply blocks execution until it
stops.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
