jscheffl commented on code in PR #45790:
URL: https://github.com/apache/airflow/pull/45790#discussion_r1922900950
##########
airflow/ui/src/components/FlexibleForm/FieldDateTime.tsx:
##########
@@ -19,13 +19,29 @@
import { Input, type InputProps } from "@chakra-ui/react";
import type { FlexibleFormElementProps } from ".";
+import { paramPlaceholder, useParamStore } from "../TriggerDag/useParamStore";
-export const FieldDateTime = ({ name, param, ...rest }:
FlexibleFormElementProps & InputProps) => (
- <Input
- defaultValue={typeof param.value === "string" ? param.value : undefined}
- id={`element_${name}`}
- name={`element_${name}`}
- size="sm"
- type={rest.type}
- />
-);
+export const FieldDateTime = ({ name, ...rest }: FlexibleFormElementProps &
InputProps) => {
+ const { paramsDict, setParamsDict } = useParamStore();
+ const param = paramsDict[name] ?? paramPlaceholder;
+ const handleChange = (value: string) => {
+ const date = new Date(value);
Review Comment:
Can this go wrong if the user has a special locale or enters "garbage" into
the input field? Should there be a try/catch just to be safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
