vincbeck commented on code in PR #45862:
URL: https://github.com/apache/airflow/pull/45862#discussion_r1925458855
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -90,18 +91,22 @@ def get_user_display_name(self) -> str:
"""Return the user's display name associated to the user in session."""
return self.get_user_name()
- @abstractmethod
+ @deprecated(
Review Comment:
That was one of the reason. The other reason is, it is still unclear to me
what the new UI needs. Are we thinking displaying user info on the UI? Are we
thinking having a link towards a user profile page like the legacy UI? Maybe
that's a question for @bbovenzi
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -121,17 +126,25 @@ def get_user_id(self) -> str | None:
return str(user_id)
return None
- @abstractmethod
+ @deprecated(
+ reason="Only used in Airflow 2 legacy UI. Will be deleted soon.",
+ category=RemovedInAirflow3Warning,
+ )
def is_logged_in(self) -> bool:
"""Return whether the user is logged in."""
+ raise NotImplementedError()
@abstractmethod
def get_url_login(self, **kwargs) -> str:
"""Return the login page url."""
- @abstractmethod
+ @deprecated(
+ reason="Only used in Airflow 2 legacy UI. Will be deleted soon.",
Review Comment:
I dont think so. Logging out means session. There is no session in AF3, we
are using a JWT token to authenticate and authorize. Once the user is
authenticate, the JWT token still be stored in the session storage (front-end).
To log out users, the front-end will just need to delete this token from the
session storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
