[ https://issues.apache.org/jira/browse/AIRFLOW-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943140#comment-16943140 ]
ASF subversion and git services commented on AIRFLOW-5490: ---------------------------------------------------------- Commit b35972fc9c727065097f0654a40a0fe39890b204 in airflow's branch refs/heads/master from Ash Berlin-Taylor [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b35972f ] Revert "[AIRFLOW-5490] Fix incorrect None comparison (#6109)" (#6222) This reverts commit 65600048b5b8f235d40a08080e5c7b1721d1d7d6. > security.py: Fix incorrect None comparison > ------------------------------------------ > > Key: AIRFLOW-5490 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5490 > Project: Apache Airflow > Issue Type: Bug > Components: security > Affects Versions: 1.10.6 > Reporter: Jakob Homan > Priority: Minor > Labels: ccoss2019, newbie > > Note: This ticket's being created to facilitate a new contributor's workshop > for Airflow. After the workshop has completed, I'll mark these all available > for anyone that might like to take them on. > In security.py, we twice use ``==`` with ``None``, which is [not > correct|https://stackoverflow.com/a/3257957] > airflow/www/security.py:343 > {code:python} > sqla_models.PermissionView.permission == None, # noqa pylint: > disable=singleton-comparison > sqla_models.PermissionView.view_menu == None, # noqa pylint: > disable=singleton-comparison > )) {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)