jscheffl commented on code in PR #45968: URL: https://github.com/apache/airflow/pull/45968#discussion_r1927200786
########## airflow/ui/src/components/MarkAs/MarkAsAccordion.tsx: ########## @@ -0,0 +1,72 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Editable, Text, VStack } from "@chakra-ui/react"; +import type { ChangeEvent } from "react"; + +import type { DAGRunResponse } from "openapi/requests/types.gen"; +import ReactMarkdown from "src/components/ReactMarkdown"; +import { Accordion } from "src/components/ui"; + +type Props = { + readonly note: DAGRunResponse["note"]; + readonly setNote: (value: string) => void; +}; + +const MarkAsAccordion = ({ note, setNote }: Props) => ( Review Comment: Oh, a I even was confused by the same two times... it is to "Mark Run As" and this is the sub component Accordion for this... ########## airflow/ui/src/components/MarkAs/MarkAsAccordion.tsx: ########## @@ -0,0 +1,72 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Editable, Text, VStack } from "@chakra-ui/react"; +import type { ChangeEvent } from "react"; + +import type { DAGRunResponse } from "openapi/requests/types.gen"; +import ReactMarkdown from "src/components/ReactMarkdown"; +import { Accordion } from "src/components/ui"; + +type Props = { + readonly note: DAGRunResponse["note"]; + readonly setNote: (value: string) => void; +}; + +const MarkAsAccordion = ({ note, setNote }: Props) => ( Review Comment: Oh, I was confused about the name as "Mark as..." for me was more related to "marking something as" and not "Markdown as Accordion". How about renaming this to `MarkdownAsAccordion`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
