Fokko commented on a change in pull request #6246: [AIRFLOW-5586] Improve CLI
error messaging
URL: https://github.com/apache/airflow/pull/6246#discussion_r330867874
##########
File path: airflow/bin/cli.py
##########
@@ -1433,8 +1435,9 @@ def users_manage_role(args, remove=False):
args.username or args.email))
role = appbuilder.sm.find_role(args.role)
+ valid_roles = appbuilder.sm.get_all_roles()
Review comment:
Can you move this inside of the `if` statement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
