ashb opened a new pull request, #46021:
URL: https://github.com/apache/airflow/pull/46021
While this wasn't a problem before, having `ti.run` in the dagrun tests makes
porting code to the TaskSDK much more complicated. It also arguably makes
them
more of integration tests than unit tests, which is no bad thing in and of
itself, but `ti.run()` can't work on SerializedDAG, so it means that the
tests
are not quite representative of what the Scheduler will actually be doing.
Most of this change is to swap from calling run to setting the state (and
sometimes adding a TaskMap row) and then checking the scheduling decisions
result.
I have added the need_serialized_dag marker to the tests I touched. In the
next PR I create (that I extracted this out of) I apply this marker to all
the
entire file, but that also needs porting manny of the dynamic task mapping
tests, and since I will be moving those soon I didn't touch them here too.
The test_prev_dagrun_dep file has been removed as it was only used in two
specific tests in this file, so it's better to inline it directly there.
How is this change deleting so many files? By removing duplicated or
almost-duplicated tests, namely these pairs. There were too many tests that
had almost identical bodies.
For example, testing that reducing a map length to zero isn't noticably
different to testing that a map length reduces by 2.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
