AndyN5 opened a new issue, #46026:
URL: https://github.com/apache/airflow/issues/46026

   ### Apache Airflow version
   
   2.10.4
   
   ### If "Other Airflow 2 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   # Bug in `CreateCustomTrainingJobOperator` with Parent Model Resource ID 
Validation
   
   ## Description
   The `CreateCustomTrainingJobOperator` introduced in [PR 
#38584](https://github.com/apache/airflow/pull/38584) has been found to have a 
flaw. An error occurs during the parsing and validation of the resource ID of 
the parent model when this operator is used to train new models based on parent 
models. This problem shows up as follows:
   
   There is an impact on both synchronous and deferrable modes.
   **When It Occurs**: Right after a kid model's training job is submitted.
   
   
   
   
   ## Expected Behavior
   For the training task to run error-free, the operator must properly parse 
and validate the resource ID of the parent model.
   
   ## Actual Behavior
   When the resource ID of the parent model is handled incorrectly, the job 
submission fails.
   
   ## Impact
   Workflows that depend on parent-child model training configurations are 
disrupted by this flaw, making them unusable until it is fixed.
   
   ## Suggested Resolution
   Examine the `CreateCustomTrainingJobOperator`'s parsing mechanism for parent 
model resource IDs.
   2. Fix any problems found to guarantee synchronous and deferrable mode 
compatibility.
   3. Include the necessary unit tests to support parent model resource ID 
scenarios.
   
   
   ## Proposed Solution
   This issue affects both the core functionality and newly introduced 
deferrable mode of the operator. Users relying on parent model training 
workflows may require an interim workaround.
   
   
   
   ### What you think should happen instead?
   
   _No response_
   
   ### How to reproduce
   
   ## How to reproduce
   1. To submit a training task for a new model that references a parent model, 
use the `CreateCustomTrainingJobOperator`.
   2. Verify that the task parameters include the resource ID of the parent 
model.
   3. Send in the work and see the problem pertaining to the validation and 
parsing of the resource ID.
   
   ### Operating System
   
   windows
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Official Apache Airflow Helm Chart
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to