jedcunningham commented on code in PR #45483:
URL: https://github.com/apache/airflow/pull/45483#discussion_r1929219709
##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -264,6 +264,7 @@ spec:
{{- if .Values.scheduler.logGroomerSidecar.args }}
args: {{- tpl (toYaml .Values.scheduler.logGroomerSidecar.args) . |
nindent 12 }}
{{- end }}
+ envFrom: {{- include "custom_airflow_environment_from" . | default
"\n []" | indent 10 }}
Review Comment:
It feels a little weird to include the custom env if we aren't also
including the standard env.
There is also #46003 that was opened to allow custom env vars just for the
log groomers, which is probably a better answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
