jedcunningham commented on code in PR #46003:
URL: https://github.com/apache/airflow/pull/46003#discussion_r1929229552
##########
chart/values.schema.json:
##########
@@ -12175,6 +12175,16 @@
"type": "integer",
"default": 15
},
+ "env": {
+ "description": "Add additional env vars to log groomer
sidecar container.",
Review Comment:
```suggestion
"description": "Add additional env vars to log groomer
sidecar container (templated).",
```
##########
tests/charts/log_groomer.py:
##########
@@ -90,6 +90,19 @@ def test_log_groomer_collector_default_retention_days(self):
)
assert
jmespath.search("spec.template.spec.containers[1].env[0].value", docs[0]) ==
"15"
+ def test_log_groomer_collector_custom_env(self):
+ env = {"name": "ENABLE_KUBE_MUTATION_TYPE", "value": "upsert"}
Review Comment:
It'd be worth refactoring this test so it exercises the templating.
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -210,13 +210,16 @@ spec:
{{- if .Values.dagProcessor.logGroomerSidecar.args }}
args: {{- tpl (toYaml .Values.dagProcessor.logGroomerSidecar.args) .
| nindent 12 }}
{{- end }}
- {{- if .Values.dagProcessor.logGroomerSidecar.retentionDays }}
env:
+ {{- if .Values.dagProcessor.logGroomerSidecar.retentionDays }}
- name: AIRFLOW__LOG_RETENTION_DAYS
value: "{{ .Values.dagProcessor.logGroomerSidecar.retentionDays
}}"
- name: AIRFLOW_HOME
Review Comment:
Like discussed
[here](https://github.com/astronomer/airflow/pull/1517#discussion_r1927690672),
we should set AIRFLOW_HOME regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
