jedcunningham commented on code in PR #45779:
URL: https://github.com/apache/airflow/pull/45779#discussion_r1929923587
##########
airflow/cli/cli_config.py:
##########
@@ -172,8 +172,12 @@ def string_lower_type(val):
"--bundle-name",
),
help=("The name of the DAG bundle to use."),
+ type=str,
default=None,
)
+ARG_LATEST_BUNDLE_VERSION = Arg(
Review Comment:
We don't need to expose a version arg, just name.
##########
airflow/cli/commands/remote_commands/dag_command.py:
##########
@@ -328,7 +331,25 @@ def dag_list_dags(args, session=NEW_SESSION) -> None:
f"List of valid columns: {list(dag_schema.fields.keys())}",
file=sys.stderr,
)
- dagbag = DagBag(process_subdir(args.subdir))
Review Comment:
We should instead use `DagBag(read_dags_from_db=True)`. We don't want to
reparse everything - it's better to show what the DAG processor has already
parsed.
As I mentioned in the issue, #45665 will move this to an api call anyways -
using the DagBag to read from the db is a small step in that direction - but
long term, we definitely cannot reparse!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
