jscheffl commented on code in PR #45958:
URL: https://github.com/apache/airflow/pull/45958#discussion_r1931231945
##########
providers/edge/src/airflow/providers/edge/cli/edge_command.py:
##########
@@ -395,9 +397,11 @@ def heartbeat(self) -> None:
if _EdgeWorkerCli.maintenance_mode:
logger.info("Exit Maintenance mode requested!")
_EdgeWorkerCli.maintenance_mode = False
+ worker_state_changed = worker_info.state == state
Review Comment:
Are you sure this is the _right_ check? Why has the state changed when the
server response equals the reported state?
##########
providers/edge/src/airflow/providers/edge/openapi/edge_worker_api_v1.yaml:
##########
Review Comment:
I am not sure whether the changes on API return value (list->Pydantic Model)
will work with Airflow 2.10 - the OpenAPI Manifest needs to be adjusted? Or is
the change working without? Because only the new ENUM values are added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
