marinajpereira commented on issue #6196: [AIRFLOW-3152] Kubernetes Pod Operator should support init containers. URL: https://github.com/apache/airflow/pull/6196#issuecomment-538098660 > I would suggest instead of implementing a custom object (`InitContainer`) that you allow users to pass the the`kubernetes.client.models.V1Container` object directly. Your `InitContainer` only implements a small portion of the full `kubernetes.client.models.V1Container`and requires additional code to convert to the appropriate object. This should lower the complexity and increase the functionality of this PR significantly. The old Airflow Kubernetes objects are only there for backwards compatibility API reasons. @davlum Thanks for your review on this PR. I would like some clarification on your comment. 1. When you say old Airflow Kubernetes objects, do you mean the custom objects such as: `Secret`, `VolumeMount`, `Volume`,..? 2. Are you suggesting that I allow users to define the container using the model `kubernetes.client.models.V1Container` and then pass it as `List[k8s.V1Container]` to `init_containers` in KubernetesPodOperator object?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
