jedcunningham commented on code in PR #46163:
URL: https://github.com/apache/airflow/pull/46163#discussion_r1931510643
##########
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:
##########
@@ -205,7 +205,7 @@ def placeholder(self) -> str:
return self._placeholder
@property
- def insert_statement_format(self) -> str:
+ def insert_statement_format(self) -> str | None:
Review Comment:
Won't this always be a str though? If it's falsey, it goes looks at the
connection extra, does a get and has a fallback, this returning a str.
MyPy might be happier with a `if self._insert_statement_format is None:`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
