serkef commented on a change in pull request #6175: [AIRFLOW-5545] Fixes
recursion in DAG cycle testing
URL: https://github.com/apache/airflow/pull/6175#discussion_r331251572
##########
File path: airflow/models/dag.py
##########
@@ -1467,22 +1467,26 @@ def _test_cycle_helper(self, visit_map, task_id):
"""
from airflow.models.dagbag import DagBag # Avoid circular imports
- # print('Inspecting %s' % task_id)
- if visit_map[task_id] == DagBag.CYCLE_DONE:
- return False
-
- visit_map[task_id] = DagBag.CYCLE_IN_PROGRESS
-
- task = self.task_dict[task_id]
- for descendant_id in task.get_direct_relative_ids():
- if visit_map[descendant_id] == DagBag.CYCLE_IN_PROGRESS:
- msg = "Cycle detected in DAG. Faulty task: {0} to {1}".format(
- task_id, descendant_id)
+ path, visited = [task_id], []
Review comment:
I think using a `deque` would be more appropriate here as it [reduces
costs](https://docs.python.org/3.6/library/collections.html#collections.deque)
of insertion (`append`) and deletion (`pop`)
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
