potiuk commented on code in PR #46064:
URL: https://github.com/apache/airflow/pull/46064#discussion_r1932438404
##########
dev/breeze/src/airflow_breeze/utils/parallel.py:
##########
@@ -458,6 +458,8 @@ def check_async_run_results(
for output in outputs:
Path(output.file_name).unlink(missing_ok=True)
+ return tests_failed
Review Comment:
The right solution here will be:
```
if tests_failed:
sys.exit(1)
```
The problem is that we do not check the result of `check_async_run_results`
- the method was supposed to "sys.exit(1)` here rather than return False.
My bad I have not noticed it :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
