jedcunningham commented on code in PR #46164:
URL: https://github.com/apache/airflow/pull/46164#discussion_r1934457412
##########
airflow/dag_processing/manager.py:
##########
@@ -498,7 +495,12 @@ def _refresh_dag_bundles(self):
bundle_file_paths = self._find_files_in_bundle(bundle)
+ # Now that we have the files present in the latest bundle,
+ # we need to update the file paths to include any new ones
+ # and remove any that are no longer in the bundle.
+ # We do this by removing all existing files that are in this bundle
new_file_paths = [f for f in self._file_paths if f.bundle_name !=
bundle.name]
+ # And then add all the current files in
Review Comment:
It's a carry-on of the previous comment block. But I can reword it a bit, no
problem.
##########
airflow/dag_processing/manager.py:
##########
@@ -498,7 +495,12 @@ def _refresh_dag_bundles(self):
bundle_file_paths = self._find_files_in_bundle(bundle)
+ # Now that we have the files present in the latest bundle,
+ # we need to update the file paths to include any new ones
+ # and remove any that are no longer in the bundle.
+ # We do this by removing all existing files that are in this bundle
new_file_paths = [f for f in self._file_paths if f.bundle_name !=
bundle.name]
+ # And then add all the current files in
Review Comment:
```suggestion
# we need to update file_paths to include any new files
# and remove any files that are no longer in the bundle.
# We do this by removing all existing files that are in this
bundle
# and then adding all the current files back in.
new_file_paths = [f for f in self._file_paths if f.bundle_name
!= bundle.name]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
