jedcunningham commented on code in PR #46226:
URL: https://github.com/apache/airflow/pull/46226#discussion_r1934609173
##########
airflow/dag_processing/bundles/git.py:
##########
@@ -236,6 +238,8 @@ def view_url(self, version: str | None = None) -> str |
None:
return None
if url.startswith("git@"):
url = self._convert_git_ssh_url_to_https(url)
+ if url.endswith(".git"):
+ url = url[:-4]
Review Comment:
Generally I agree @josix - but in this case being right under the `endswith`
condition, the int is easier to read imo.
##########
airflow/config_templates/config.yml:
##########
@@ -2680,7 +2680,14 @@ dag_processor:
"classpath": "airflow.dag_processing.bundles.git.GitDagBundle",
"kwargs": {
"subdir": "dags",
- "repo_url": "[email protected]:example.com/my-dags.git",
+ "tracking_ref": "main",
+ "refresh_interval": 0
+ },
+ {
+ "name": "my-git-repo",
+ "classpath": "airflow.dag_processing.bundles.git.GitDagBundle",
+ "kwargs": {
+ "subdir": "dags",
"tracking_ref": "main",
"refresh_interval": 0
Review Comment:
```suggestion
```
We don't really need 2 examples of the same bundle config in there :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
