ashb opened a new pull request, #46265:
URL: https://github.com/apache/airflow/pull/46265
Closes #45426
Some points of note about this PR:
- Logging is changed in Celery, but only for Airflow 3
Celery does it's own "capture stdout" logging, which conflicts with the
ones
we do in the TaskSDK, so we disable that; but to not change anything for
Airflow 3.
- Simplify task SDK logging redirection
As part of this discovery that Celery captures stdout/stderr itself (and
before disabling that) I discovered a simpler way to re-open the
stdin/out/err so that the implementation needs fewer/no special casing.
- Make JSON task logs more readable by giving them a consistent/useful order
We re-order (by re-creating) the event_dict so that timestamp, level, and
then even are always the first items in the dict
- Makes the CeleryExecutor understand the concept of "workloads" instead a
command tuple.
This change isn't done in the best way, but until Kube executor is swapped
over (and possibly the other in-tree executors, such as ECS) we need to
support both styles concurrently.
The change should be done in such a way that the provider still works with
Airflow v2, if it's running on that version.
- Upgrade Celery
This turned out to not be 100% necessary but it does fix some deprecation
warnings when running on Python 3.12
- Ensure that the forked process in TaskSDK _never ever_ exits
Again, this isn't possible usually, but since the setup step of
`_fork_main`
died, it didn't call `os._exit()`, and was caught further up, which meant
the process stayed alive as it never closed the sockets properly. We put
and
extra safety try/except block in place to catch that
I have not yet included a newsfragment for changing the executor interface as
the old style is _currently_ still supported.
Testing: I ran `airflow scheduler`, `airflow fastapi-api`, and `airflow
celery
worker` and triggered some dags, viewed logs etc.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
