[
https://issues.apache.org/jira/browse/AIRFLOW-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor updated AIRFLOW-5488:
---------------------------------------
Description:
Note: This ticket's being created to facilitate a new contributor's workshop
for Airflow. After the workshop has completed, I'll mark these all available
for anyone that might like to take them on.
The {{tmp_configuration_copy}} function in airflow/utils/configuration.py has
two parameters, `include_env` and `include_cmds` that are never used but should
be! {{conf.as_dict}} accepts include_env and include_cmds properties and these
should be passed on.
was:
Note: This ticket's being created to facilitate a new contributor's workshop
for Airflow. After the workshop has completed, I'll mark these all available
for anyone that might like to take them on.
This method for making a temporary file with configuration has two parameters,
`include_env` and `include_cmds` that are never used and should be removed.
airflow/utils/configuration.py:27
{code:java}
def tmp_configuration_copy(chmod=0o600, include_env=True, include_cmds=True):
"""
Returns a path for a temporary file including a full copy of the
configuration
settings.
:return: a path to a temporary file
"""
cfg_dict = conf.as_dict(display_sensitive=True, raw=True)
temp_fd, cfg_path = mkstemp()
with os.fdopen(temp_fd, 'w') as temp_file:
# Set the permissions before we write anything to it.
if chmod is not None:
os.fchmod(temp_fd, chmod)
json.dump(cfg_dict, temp_file)
return cfg_path {code}
> Respect include_env and include_cmds in tmp_configuration_copy method
> ---------------------------------------------------------------------
>
> Key: AIRFLOW-5488
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5488
> Project: Apache Airflow
> Issue Type: Bug
> Components: core
> Affects Versions: 1.10.6
> Reporter: Jakob Homan
> Priority: Minor
> Labels: ccoss2019, newbie
>
> Note: This ticket's being created to facilitate a new contributor's workshop
> for Airflow. After the workshop has completed, I'll mark these all available
> for anyone that might like to take them on.
> The {{tmp_configuration_copy}} function in airflow/utils/configuration.py has
> two parameters, `include_env` and `include_cmds` that are never used but
> should be! {{conf.as_dict}} accepts include_env and include_cmds properties
> and these should be passed on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
