pierrejeambrun commented on code in PR #45977:
URL: https://github.com/apache/airflow/pull/45977#discussion_r1935303967
##########
airflow/ui/src/queries/usePatchDagRun.ts:
##########
@@ -45,7 +48,12 @@ export const usePatchDagRun = ({
const queryClient = useQueryClient();
const onSuccessFn = async () => {
- const queryKeys = [UseDagRunServiceGetDagRunKeyFn({ dagId, dagRunId }),
[useDagRunServiceGetDagRunsKey]];
+ const queryKeys = [
+ UseDagRunServiceGetDagRunKeyFn({ dagId, dagRunId }),
+ [useDagRunServiceGetDagRunsKey],
+ [useTaskInstanceServiceGetTaskInstancesKey, { dagId, dagRunId }],
Review Comment:
I don't think this is working.
The reason you see tasks being reloaded is because of the cache invalidation
coming from.`useTaskInstanceServiceGetTaskInstancesKey` in `useClearRun.ts`.
I just tried this syntax, and it's working, I know the syntax is weird but
that's how it's defined in our generated code.
```
UseTaskInstanceServiceGetTaskInstancesKeyFn({ dagId, dagRunId }, [{ dagId,
dagRunId }])
```
Maybe you can also update the call to
`useTaskInstanceServiceGetTaskInstancesKey` in `useClearRun`. I don't think we
should be clearing all TI calls.
For `usePatchTaskInstance` though, we need to clear per dagId. (because of
past/future we need to not be specific on the 'dagRun').
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
