jedcunningham commented on code in PR #46178: URL: https://github.com/apache/airflow/pull/46178#discussion_r1935911308
########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. Review Comment: ```suggestion tasks are executed. Teardown tasks are skipped if the setup was also skipped. ``` ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" Review Comment: ```suggestion Ensure teardown tasks are executed when DAG run is set to failed (#45530) """"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" ``` ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) Review Comment: ```suggestion - Fix ShortCircuitOperator mapped tasks (#44912) ``` ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) +- Fix premature evaluation in mapped task group (#44937) Review Comment: ```suggestion - Fix premature evaluation of tasks with certain trigger rules (e.g. ``ONE_DONE``) in a mapped task group (#44937) ``` ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) +- Fix premature evaluation in mapped task group (#44937) +- Fix task_id validation in BaseOperator (#44938) (#44938) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) +- Fix ``FileTaskHandler`` only read from default executor (#46000) +- Fix empty task instance for log (#45702) (#45703) +- Remove ``skip_if`` and ``run_if`` in python source (#41832) (#45680) +- Log action get the correct request body (#45546) (#45560) +- Ensure teardown tasks are executed when DAG run is set to failed (#45530) (#45581) +- Do not update DR on TI update after task execution (#45348) +- Fix update issues for object and advanced-arrays fields when empty default (#45313) (#45315) +- Fixed the endless reschedule (#45224) (#45250) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) (#45137) +- Evaluate None in SQLAlchemy's extended JSON type decorator (#45119) (#45120) +- Allow Dynamic Tasks to be Searchable Using map_index_template (#45109) (#45122) Review Comment: ```suggestion - Allow dynamic tasks to be filtered by ``rendered_map_index`` (#45109) (#45122) ``` Have to squint pretty hard to view this one as a bugfix. It's a bug you couldn't do it before? lol ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) +- Fix premature evaluation in mapped task group (#44937) +- Fix task_id validation in BaseOperator (#44938) (#44938) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) +- Fix ``FileTaskHandler`` only read from default executor (#46000) +- Fix empty task instance for log (#45702) (#45703) +- Remove ``skip_if`` and ``run_if`` in python source (#41832) (#45680) +- Log action get the correct request body (#45546) (#45560) +- Ensure teardown tasks are executed when DAG run is set to failed (#45530) (#45581) +- Do not update DR on TI update after task execution (#45348) +- Fix update issues for object and advanced-arrays fields when empty default (#45313) (#45315) +- Fixed the endless reschedule (#45224) (#45250) Review Comment: ```suggestion - Fix endless sensor rescheduling (#45224) (#45250) ``` ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) +- Fix premature evaluation in mapped task group (#44937) +- Fix task_id validation in BaseOperator (#44938) (#44938) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) +- Fix ``FileTaskHandler`` only read from default executor (#46000) +- Fix empty task instance for log (#45702) (#45703) +- Remove ``skip_if`` and ``run_if`` in python source (#41832) (#45680) +- Log action get the correct request body (#45546) (#45560) +- Ensure teardown tasks are executed when DAG run is set to failed (#45530) (#45581) +- Do not update DR on TI update after task execution (#45348) +- Fix update issues for object and advanced-arrays fields when empty default (#45313) (#45315) +- Fixed the endless reschedule (#45224) (#45250) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) (#45137) +- Evaluate None in SQLAlchemy's extended JSON type decorator (#45119) (#45120) +- Allow Dynamic Tasks to be Searchable Using map_index_template (#45109) (#45122) +- Handle relative paths when sanitizing URLs (#41995) (#45080) +- Set Autocomplete Off on Login Form (#44929) (#44940) +- Add Webserver parameters ``max_form_parts``, ``max_form_memory_size`` (#46243) (#45749) +- Fixed thread local _sentinel.callers defect and added test cases (#44646) (#46280) + + +Miscellaneous +""""""""""""" + +- Deprecate conf from Task Context (#44968) Review Comment: ```suggestion ``` Already listed below - and this one didn't end up sticking anyways. ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) +- Fix premature evaluation in mapped task group (#44937) +- Fix task_id validation in BaseOperator (#44938) (#44938) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) +- Fix ``FileTaskHandler`` only read from default executor (#46000) +- Fix empty task instance for log (#45702) (#45703) +- Remove ``skip_if`` and ``run_if`` in python source (#41832) (#45680) Review Comment: ```suggestion - Remove ``skip_if`` and ``run_if`` decorators before TaskFlow virtualenv tasks are run (#41832) (#45680) ``` ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) +- Fix premature evaluation in mapped task group (#44937) +- Fix task_id validation in BaseOperator (#44938) (#44938) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) +- Fix ``FileTaskHandler`` only read from default executor (#46000) +- Fix empty task instance for log (#45702) (#45703) +- Remove ``skip_if`` and ``run_if`` in python source (#41832) (#45680) +- Log action get the correct request body (#45546) (#45560) +- Ensure teardown tasks are executed when DAG run is set to failed (#45530) (#45581) +- Do not update DR on TI update after task execution (#45348) +- Fix update issues for object and advanced-arrays fields when empty default (#45313) (#45315) +- Fixed the endless reschedule (#45224) (#45250) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) (#45137) Review Comment: ```suggestion ``` In here twice? ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) Review Comment: ```suggestion if the DAG is directly set to "failed" or "success". ``` ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) +- Fix premature evaluation in mapped task group (#44937) +- Fix task_id validation in BaseOperator (#44938) (#44938) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) +- Fix ``FileTaskHandler`` only read from default executor (#46000) +- Fix empty task instance for log (#45702) (#45703) +- Remove ``skip_if`` and ``run_if`` in python source (#41832) (#45680) +- Log action get the correct request body (#45546) (#45560) Review Comment: ```suggestion - Fix request body for json requests in event log (#45546) (#45560) ``` ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) Review Comment: Don't forget to bump this. ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) +- Fix premature evaluation in mapped task group (#44937) +- Fix task_id validation in BaseOperator (#44938) (#44938) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) +- Fix ``FileTaskHandler`` only read from default executor (#46000) +- Fix empty task instance for log (#45702) (#45703) +- Remove ``skip_if`` and ``run_if`` in python source (#41832) (#45680) +- Log action get the correct request body (#45546) (#45560) +- Ensure teardown tasks are executed when DAG run is set to failed (#45530) (#45581) +- Do not update DR on TI update after task execution (#45348) +- Fix update issues for object and advanced-arrays fields when empty default (#45313) (#45315) Review Comment: ```suggestion - Fix object and array DAG params that have a None default (#45313) (#45315) ``` ########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,60 @@ .. towncrier release notes start +Airflow 2.10.5 (2025-01-28) +--------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Ensure teardown tasks are executed when DAG run is set to failed +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Previously when a DAG run was manually set to "failed" or to "success" state the terminal state was set to all tasks. +But this was a gap for cases when setup- and teardown tasks were defined: If teardown was used to clean-up infrastructure +or other resources, they were also skipped and thus resources could stay allocated. + +As of now when setup tasks had been executed before and the DAG is manually set to "failed" or "success" then teardown +tasks are executed. Teardown tasks are skipped if the setup was also skipped. + +As a side effect this means if the DAG contains teardown tasks, then the manual marking of DAG as "failed" or "success" +will need to keep the DAG in running state to ensure that teardown tasks will be scheduled. They would not be scheduled +if the DAG is directly set to "failed" or "success". (#45530) + + +Bug Fixes +""""""""" + +- Prevent using ``trigger_rule=TriggerRule.ALWAYS`` in a task-generated mapping within bare tasks (#44751) +- Fix short circuit in mapped tasks (#44912) +- Fix premature evaluation in mapped task group (#44937) +- Fix task_id validation in BaseOperator (#44938) (#44938) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) +- Fix ``FileTaskHandler`` only read from default executor (#46000) +- Fix empty task instance for log (#45702) (#45703) +- Remove ``skip_if`` and ``run_if`` in python source (#41832) (#45680) +- Log action get the correct request body (#45546) (#45560) +- Ensure teardown tasks are executed when DAG run is set to failed (#45530) (#45581) +- Do not update DR on TI update after task execution (#45348) +- Fix update issues for object and advanced-arrays fields when empty default (#45313) (#45315) +- Fixed the endless reschedule (#45224) (#45250) +- Allow fetching XCom with forward slash from the API and escape it in the UI (#45134) (#45137) +- Evaluate None in SQLAlchemy's extended JSON type decorator (#45119) (#45120) +- Allow Dynamic Tasks to be Searchable Using map_index_template (#45109) (#45122) +- Handle relative paths when sanitizing URLs (#41995) (#45080) +- Set Autocomplete Off on Login Form (#44929) (#44940) +- Add Webserver parameters ``max_form_parts``, ``max_form_memory_size`` (#46243) (#45749) +- Fixed thread local _sentinel.callers defect and added test cases (#44646) (#46280) Review Comment: ```suggestion - Fixed accessing thread local variable in BaseOperators ``execute`` safeguard mechanism (#44646) (#46280) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
