jedcunningham commented on PR #46353: URL: https://github.com/apache/airflow/pull/46353#issuecomment-2629738056
I agree with Jens that there is value in having them go through CI. If it's half baked and a bunch of tests are failing, you won't catch any flak at all. In fact, it's nice you can defer notifying reviewers until you know everything is green, particularly if you think tests across a lot of places may fail. I do it pretty often myself. We already use [selective checks](https://github.com/apache/airflow/blob/main/dev/breeze/doc/ci/04_selective_checks.md) to optimize and only run tests that need to run for a given change. I'm sure there is still gains to be had, but the low hanging fruit is already picked there (at least afaik 😄). Thanks for the PR, but I'm going to close this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
