jedcunningham commented on code in PR #46394:
URL: https://github.com/apache/airflow/pull/46394#discussion_r1939907065
##########
tests/dag_processing/test_dag_bundles.py:
##########
@@ -506,3 +506,14 @@ def test_clone_repo_no_such_path_error(self, mock_githook):
bundle._clone_repo_if_required()
assert "Repository path: %s not found" in str(exc_info.value)
+
+ @mock.patch("airflow.dag_processing.bundles.git.GitDagBundle.log")
+ def test_repo_url_access_doesnt_error(self, mock_log):
+ bundle = GitDagBundle(
+ name="testa",
+ tracking_ref="main",
+ git_conn_id="unknown",
+ repo_url="repo_url",
+ )
+ assert bundle.repo_url
Review Comment:
```suggestion
repo_url="some_repo_url",
)
assert bundle.repo_url == "some_repo_url"
```
##########
tests/dag_processing/test_dag_bundles.py:
##########
@@ -506,3 +506,14 @@ def test_clone_repo_no_such_path_error(self, mock_githook):
bundle._clone_repo_if_required()
assert "Repository path: %s not found" in str(exc_info.value)
+
+ @mock.patch("airflow.dag_processing.bundles.git.GitDagBundle.log")
+ def test_repo_url_access_doesnt_error(self, mock_log):
Review Comment:
```suggestion
def test_repo_url_access_missing_connection_doesnt_error(self, mock_log):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
