amoghrajesh opened a new pull request, #46406:
URL: https://github.com/apache/airflow/pull/46406
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
For errrors like 500, we retry 10 times, reducing it would be better to fail
faster and improving logs to show the method and reason for retry
Logs before making changes:
```
PASSED [100%][2025-02-04T09:46:18.711+0530] {_client.py:1026} INFO -
HTTP Request: GET test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500
Internal Server Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:46:18 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 1st time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:46:18.715+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:46:18 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 2nd time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:46:18.715+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:46:18 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 3rd time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:46:18.715+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:46:18 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 4th time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:46:18.716+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:46:18 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 5th time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:46:18.716+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:46:18 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 6th time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:46:18.716+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:46:18 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 7th time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:46:18.717+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:46:18 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 8th time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:46:18.717+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:46:18 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 9th time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:46:18.717+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:46:18 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
```
Logs after making changes:
```
PASSED [100%][2025-02-04T09:41:23.045+0530] {_client.py:1026} INFO -
HTTP Request: GET test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500
Internal Server Error"
2025-02-04 09:41:28 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:41:28 [warning ] Retrying request due to HTTP error
[airflow.sdk.api.client] extra={'method': 'GET', 'url':
'xcoms/dag_id/run_id/task_id/key', 'status_code': 500, 'reason': '{"reason":
"invalid_format", "message": "XCom value is not a valid JSON"}'}
2025-02-04 09:41:28 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 1st time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:41:28.542+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:41:30 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:41:30 [warning ] Retrying request due to HTTP error
[airflow.sdk.api.client] extra={'method': 'GET', 'url':
'xcoms/dag_id/run_id/task_id/key', 'status_code': 500, 'reason': '{"reason":
"invalid_format", "message": "XCom value is not a valid JSON"}'}
2025-02-04 09:41:30 [warning ] Starting call to
'airflow.sdk.api.client.Client.request', this is the 2nd time calling it.
[airflow.sdk.api.client]
[2025-02-04T09:41:30.031+0530] {_client.py:1026} INFO - HTTP Request: GET
test://server/xcoms/dag_id/run_id/task_id/key "HTTP/1.1 500 Internal Server
Error"
2025-02-04 09:41:30 [warning ] Server error
[airflow.sdk.api.client] detail={'reason': 'invalid_format', 'message': 'XCom
value is not a valid JSON'}
2025-02-04 09:41:30 [warning ] Retrying request due to HTTP error
[airflow.sdk.api.client] extra={'method': 'GET', 'url':
'xcoms/dag_id/run_id/task_id/key', 'status_code': 500, 'reason': '{"reason":
"invalid_format", "message": "XCom value is not a valid JSON"}'}
```
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
