[
https://issues.apache.org/jira/browse/AIRFLOW-5141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944867#comment-16944867
]
ASF GitHub Bot commented on AIRFLOW-5141:
-----------------------------------------
Sinsin1367 commented on pull request #6261: [AIRFLOW-5141] Added optional
resource usage logging to KubernetesPod…
URL: https://github.com/apache/airflow/pull/6261
…Operator.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5141
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
This PR implement periodic resource fetching and keeping a max resource
usage (CPU and memory) per container for pod in KubernetesPodOperator. The
fetch frequency and log frequency are configurable to avoid excessive logging.
There will be reports on maximum CPU usage and memory usage per container at
the end of the job.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good
The PodUsageMetricsLogger class is tested in all sensible ways I could think
of.
reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> KubernetesPodOperator to print resource utilization at end of job
> -----------------------------------------------------------------
>
> Key: AIRFLOW-5141
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5141
> Project: Apache Airflow
> Issue Type: Improvement
> Components: operators
> Affects Versions: 1.10.4
> Reporter: Chris McLennon
> Assignee: Sina Asadallahi
> Priority: Minor
>
> It would be fantastic if the KubernetesPodOperator printed out a pod's max
> CPU/mem after it completes. This would give users a better idea of how many
> resources they should be requesting for their jobs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
