pierrejeambrun commented on code in PR #46074: URL: https://github.com/apache/airflow/pull/46074#discussion_r1940950377
########## airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx: ########## @@ -0,0 +1,45 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Box, Button, Heading, HStack } from "@chakra-ui/react"; +import { useParams } from "react-router-dom"; + +import { useTaskInstanceServiceGetExtraLinks } from "openapi/queries"; + +export const ExtraLinks = () => { + // TODO: Add support for mapped tasks using map_index once API support is available Review Comment: This has been merged in https://github.com/apache/airflow/pull/46107. I think we can update. ########## airflow/ui/src/pages/TaskInstance/Details.tsx: ########## @@ -85,6 +88,8 @@ export const Details = () => { taskInstance={taskInstance} /> )} + <ExtraLinks /> Review Comment: Maybe we also need a header with "General" or something so separate 'links', 'trigger info' and 'general info'. Just an idea ########## airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx: ########## @@ -0,0 +1,45 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Box, Button, Heading, HStack } from "@chakra-ui/react"; +import { useParams } from "react-router-dom"; + +import { useTaskInstanceServiceGetExtraLinks } from "openapi/queries"; + +export const ExtraLinks = () => { + // TODO: Add support for mapped tasks using map_index once API support is available + const { dagId = "", runId = "", taskId = "" } = useParams(); + const { data, isLoading } = useTaskInstanceServiceGetExtraLinks({ dagId, dagRunId: runId, taskId }); + + return !isLoading && data !== undefined && Object.keys(data).length > 0 ? ( + <Box py={2}> + <Heading size="sm"> Extra Links </Heading> + <HStack gap={2} py={2}> + {Object.keys(data).map((key) => Review Comment: Nit: You can map over `Object.entries` as well to avoid multiple accessor like `data[key]` ########## airflow/ui/src/pages/TaskInstance/Details.tsx: ########## @@ -85,6 +88,8 @@ export const Details = () => { taskInstance={taskInstance} /> )} + <ExtraLinks /> Review Comment: For now both table are next to each other like this:  ########## airflow/ui/src/pages/TaskInstance/Details.tsx: ########## @@ -85,6 +88,8 @@ export const Details = () => { taskInstance={taskInstance} /> )} + <ExtraLinks /> + {taskInstance?.state === "deferred" && <TriggererInfo taskInstance={taskInstance} />} Review Comment: I'm not sure we only want to show TriggererInfo for tasks in deferred state. If a task has been resumed and is settled (success failed etc..) I still think this is a relevant information. If fields are not None (.trigger and .trigger_job) I think we should show this section. ########## airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx: ########## @@ -0,0 +1,45 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Box, Button, Heading, HStack } from "@chakra-ui/react"; +import { useParams } from "react-router-dom"; + +import { useTaskInstanceServiceGetExtraLinks } from "openapi/queries"; + +export const ExtraLinks = () => { + // TODO: Add support for mapped tasks using map_index once API support is available + const { dagId = "", runId = "", taskId = "" } = useParams(); + const { data, isLoading } = useTaskInstanceServiceGetExtraLinks({ dagId, dagRunId: runId, taskId }); + + return !isLoading && data !== undefined && Object.keys(data).length > 0 ? ( Review Comment: ```suggestion return data && Object.keys(data).length > 0 ? ( ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
