dabla opened a new pull request, #45451:
URL: https://github.com/apache/airflow/pull/45451
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: [#45237](https://github.com/apache/airflow/issues/45237)
related: [#45237](https://github.com/apache/airflow/issues/45237)
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR allows you to define the check_response option in the extra options
fields of the HTTP connection so that you can disable the check globally for
that connection instead of always having to pass it to each HttpOperator using
that same connection id.
I also took the opportunity to refactor the get_conn method of the HttpHook
so you can easily override the default host and default headers in the
specialized hooks so those subclasses (e.g. LivyHook or DingdingHook) don't
need to override the get_conn method anymore, otherwise as the signature has
changed (e.g. added extra_options parameter) those has to be changed also and
the exisiting solution wasn't DRY also, now it is.
In the past if you want to disable the response_check in the HttpHook
through the HtpOperator, you had to define the HttpOperator like this:
```
validate_custom_fields_task = HttpOperator(
task_id="get_data",
method="GET",
http_conn_id="http_conn_id",
endpoint="/endpoint",
headers={},
response_check=response_check,
extra_options={"check_response": False}, # allows you to use the custom
response_check instead of the HttpHook buildin check
dag=dag,
)
```
Now thanks to this PR, you can define the check_response globally in the
extra_options of the connection, so it will be applied to each HttpOperator
using that connection.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
